Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: create a span for NewWriter #6144

Closed
codyoss opened this issue Jun 9, 2022 · 0 comments · Fixed by #8375
Closed

storage: create a span for NewWriter #6144

codyoss opened this issue Jun 9, 2022 · 0 comments · Fixed by #8375
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@codyoss
Copy link
Member

codyoss commented Jun 9, 2022

Storage has two very popular operations, read & write. When reading blobs the storage client creates a custom span. The same is not true however on the write side. There have been previous issue 1 2 around storage creating a lot of spans due to our default OC span path naming scheme. Although we may want to change our default span naming I think it would also be useful to change the span name for writing so be more or less symmetric to reading. Because there is not a span name today a different span name will be created for each upload since the object name is a path param.
@codyoss codyoss added api: storage Issues related to the Cloud Storage API. triage me I really want to be triaged. labels Jun 9, 2022
@danielbankhead danielbankhead added type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. priority: p3 Desirable enhancement or fix. May not be included in next release. and removed triage me I really want to be triaged. labels Jun 13, 2022
@yoshi-automation yoshi-automation added 🚨 This issue needs some love. and removed 🚨 This issue needs some love. labels Jun 15, 2022
tritone added a commit to tritone/google-cloud-go that referenced this issue Aug 2, 2023
@tritone
feat(storage): add trace span to Writer
25a887a 
Adds a trace span that covers a Writer from open to close.
Nested spans already cover individual RPCs that the Writer
makes.

Fixes googleapis#6144
@tritone tritone mentioned this issue Aug 2, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Aug 3, 2023
@tritone
feat(storage): add trace span to Writer (#8375)
f7ac85b 
Adds a trace span that covers a Writer from open to close. Nested spans already cover individual requests / RPCs that the Writer makes.

Fixes #6144
@release-please release-please bot mentioned this issue Aug 3, 2023
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

feat(storage): add trace span to Writer tritone/google-cloud-go
4 participants
@tritone @codyoss @danielbankhead @yoshi-automation