Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(bigtable): Add update value type test. #10771

Merged
merged 9 commits into from
Sep 5, 2024

Conversation

hoangpham95
Copy link
Contributor

Add new string UTF8 bytes encoding and a deprecate comment to the old encoding. Add test to update value_type of a column family.

Verified

This commit was signed with the committer’s verified signature.
apricote Julian Tölle
@hoangpham95 hoangpham95 requested review from a team as code owners August 26, 2024 19:59
@hoangpham95
Copy link
Contributor Author

hoangpham95 commented Aug 26, 2024

Integration test result:

go test -test.run="TestIntegration_UpdateFamilyValueType" -v \
-it.admin-endpoint="test-bigtableadmin.sandbox.googleapis.com:443" \
-it.project="google.com:cloud-bigtable-dev" \
-it.instance="phhoang-btql-test" \
-it.cluster="phhoang-btql-test-c1"
Note: when using prod, you must first create an instance:
cbt createinstance phhoang-btql-test phhoang-btql-test phhoang-btql-test-c1 us-central1-b 1 SSD
=== RUN   TestIntegration_UpdateFamilyValueType
--- PASS: TestIntegration_UpdateFamilyValueType (6.05s)
PASS
ok      cloud.google.com/go/bigtable    79.286s

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@bhshkh
Copy link
Contributor

bhshkh commented Aug 26, 2024

Please resolve vet failures

@bhshkh bhshkh changed the title Add update value type test. feat(bigtable): Add update value type test. Aug 26, 2024
@product-auto-label product-auto-label bot added the api: bigtable Issues related to the Bigtable API. label Aug 27, 2024
@bhshkh bhshkh enabled auto-merge (squash) September 4, 2024 18:21
auto-merge was automatically disabled September 4, 2024 18:28

Head branch was pushed to by a user without write access

@bhshkh bhshkh added kokoro:force-run Add this label to force Kokoro to re-run the tests. kokoro:run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@kokoro-team kokoro-team removed kokoro:run Add this label to force Kokoro to re-run the tests. kokoro:force-run Add this label to force Kokoro to re-run the tests. labels Sep 4, 2024
@bhshkh bhshkh merged commit 210f022 into googleapis:main Sep 5, 2024
8 of 10 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
api: bigtable Issues related to the Bigtable API.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants