Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

storage: TestIntegration_ObjectRetention failed #10229

Closed
flaky-bot bot opened this issue May 18, 2024 · 3 comments · Fixed by #10232
Closed

storage: TestIntegration_ObjectRetention failed #10229

flaky-bot bot opened this issue May 18, 2024 · 3 comments · Fixed by #10232
Assignees
@tritone
Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.

Comments

@flaky-bot
Copy link

flaky-bot bot commented May 18, 2024

This test failed!

To configure my behavior, see the Flaky Bot documentation.

If I'm commenting on this issue too often, add the flakybot: quiet label and
I will stop commenting.

commit: e2cf46b
buildURL: Build Status, Sponge
status: failed
@flaky-bot flaky-bot bot added flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns. labels May 18, 2024
@product-auto-label product-auto-label bot added the api: storage Issues related to the Cloud Storage API. label May 18, 2024
@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented May 18, 2024

commit: adf91f9
buildURL: Build Status, Sponge
status: failed

@flaky-bot Flaky Bot
Copy link
Author

flaky-bot bot commented May 20, 2024

commit: 6604953
buildURL: Build Status, Sponge
status: failed

@tritone
Copy link
Contributor

tritone commented May 20, 2024

Error in all 3 failures:
=== RUN TestIntegration_ObjectRetention/http integration_test.go:4173: failed to remove retention from object: context canceled

tritone added a commit to tritone/google-cloud-go that referenced this issue May 20, 2024
@tritone
test(storage): fix context timeout logic
63e831c 
Some tests had logic in t.Cleanup using the same context. Move
context cancellation to t.Cleanup as well so that the cancel
happens after this logic executes.

Fixes googleapis#10229
@tritone tritone mentioned this issue May 20, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@tritone tritone

Labels
api: storage Issues related to the Cloud Storage API. flakybot: issue An issue filed by the Flaky Bot. Should not be added manually. priority: p1 Important issue which blocks shipping the next release. Will be fixed prior to next release. type: bug Error or flaw in code with unintended results or allowing sub-optimal usage patterns.
Projects
None yet
Milestone
No milestone
Development

Successfully merging a pull request may close this issue.

test(storage): fix context timeout logic tritone/google-cloud-go
1 participant
@tritone