fix: Typo when setting the state for the pickle deserializer. #1479
+4
−1
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
westarle
reviewed
Feb 15, 2024
| @@ -75,7 +75,7 @@ def __getstate__(self): | |||
|
|
|||
| def __setstate__(self, state): | |||
| """Pickle helper that deserializes the _lock attribute.""" | |||
| state["_key"] = threading.Lock() | |||
| state["_lock"] = threading.Lock() | |||
There was a problem hiding this comment.
ACK - Going to wait to hear back on #1478 before doing more
clundin25
added
the
owlbot:run
gcf-owl-bot
bot
removed
the
owlbot:run
westarle
approved these changes
Feb 21, 2024
merwok
reviewed
Mar 22, 2024
| @@ -150,7 +150,10 @@ def test_refresh_dead_worker(): | |||
|
|
|||
| def test_pickle(): | |||
| w = _refresh_worker.RefreshThreadManager() | |||
| # For some reason isinstance cannot interpret threading.Lock as a type. | |||
There was a problem hiding this comment.
The reason is that threading.Lock is a function, returning instances of _thread.lock (internal class)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.