Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adding universe domain support for downscroped credentials #1463

Merged
merged 5 commits into from Feb 8, 2024
Merged

feat: adding universe domain support for downscroped credentials #1463

merged 5 commits into from Feb 8, 2024

Conversation

BigTailWolf
Copy link
Contributor

No description provided.

@BigTailWolf BigTailWolf requested review from a team as code owners February 5, 2024 23:49
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 6, 2024
lsirac
lsirac requested changes Feb 6, 2024
View reviewed changes
google/auth/credentials.py Show resolved Hide resolved
tests/test_downscoped.py Show resolved Hide resolved
google/auth/downscoped.py Show resolved Hide resolved
arithmetic1728
arithmetic1728 approved these changes Feb 6, 2024
View reviewed changes
google/auth/downscoped.py Show resolved Hide resolved
@lsirac lsirac added the do not merge Indicates a pull request not ready for merge, due to either quality or timing. label Feb 6, 2024
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 7, 2024
lsirac
lsirac approved these changes Feb 8, 2024
View reviewed changes
tests/test_downscoped.py Outdated Show resolved Hide resolved
BigTailWolf and others added 2 commits February 8, 2024 11:51
@BigTailWolf @lsirac
Update tests/test_downscoped.py
e219763 
Co-authored-by: Leo <39062083+lsirac@users.noreply.github.com>
@BigTailWolf
Merge branch 'main' into b323932229
254909a
@BigTailWolf BigTailWolf added owlbot:run Add this label to trigger the Owlbot post processor. and removed do not merge Indicates a pull request not ready for merge, due to either quality or timing. labels Feb 8, 2024
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Feb 8, 2024
@BigTailWolf BigTailWolf merged commit fa8b7b2 into googleapis:main Feb 8, 2024
15 checks passed
@release-please release-please bot mentioned this pull request Feb 8, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@arithmetic1728 arithmetic1728 arithmetic1728 approved these changes

Assignees

@lsirac lsirac

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@BigTailWolf @lsirac @arithmetic1728