Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix: read universe_domain for external account authorized user #1450

Merged
merged 4 commits into from Jan 11, 2024
Merged

fix: read universe_domain for external account authorized user #1450

merged 4 commits into from Jan 11, 2024

Conversation

arithmetic1728
Copy link
Contributor

No description provided.

@arithmetic1728 arithmetic1728 requested review from a team as code owners January 10, 2024 23:00
@arithmetic1728 arithmetic1728 changed the title Fix external fix: read universe_domain for external account authorized user Jan 10, 2024
lsirac
lsirac approved these changes Jan 10, 2024
View reviewed changes
Copy link
Contributor

@lsirac lsirac left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, just make sure this doesn't cause any regressions with gcloud given the previous fix we submitted

tests/data/external_account_authorized_user_non_gdu.json Outdated Show resolved Hide resolved
@arithmetic1728 arithmetic1728 merged commit 1cc7df3 into main Jan 11, 2024
16 checks passed
@arithmetic1728 arithmetic1728 deleted the fix_external branch January 11, 2024 00:16
@release-please release-please bot mentioned this pull request Jan 11, 2024
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lsirac lsirac lsirac approved these changes

@clundin25 clundin25 clundin25 approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
3 participants
@arithmetic1728 @lsirac @clundin25