-
Notifications
You must be signed in to change notification settings - Fork 297
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Add custom tls signer for ECP Provider. #1402
Conversation
5c1fb0f
to
cfff28f
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, just some minor comments.
self._enterprise_cert_file_path.encode("ascii"), | ||
): | ||
raise exceptions.MutualTLSChannelError( | ||
"failed to configure SSL context" |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
maybe update the error message to say which approach was used, something like "failed to configure SSL context using provider lib" / "failed to configure SSL context using offload lib". This will make it easier to identify issues.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good point, added!
@@ -197,23 +213,31 @@ def __init__(self, enterprise_cert_file_path): | |||
} | |||
""" | |||
self._enterprise_cert_file_path = enterprise_cert_file_path | |||
self._cert = None | |||
self._sign_callback = None | |||
self._provider_lib = None |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
should we keep the following lines?
self._cert = None
self._sign_callback = None
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Oh yes, that was a mistake. I'll add those back.
No description provided.