Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Invalid dev version identifiers in setup.py #1321

Closed
con-f-use opened this issue Jun 6, 2023 · 1 comment · Fixed by #1322 or #1328
Closed

Invalid dev version identifiers in setup.py #1321

con-f-use opened this issue Jun 6, 2023 · 1 comment · Fixed by #1322 or #1328

Comments

@con-f-use
Copy link
Contributor

con-f-use commented Jun 6, 2023 •
edited

There is a bunch of invalid version matchers (edit: valid, but not parsed correctly by distlib) in setup.py. PEP 440 states:

The canonical public version identifiers MUST comply with the following scheme:
[N!]N(.N)*[{a|b|rc}N][.postN][.devN]

So you are missing a dot and a number in every version identifier that contains the string dev.

It is also considered bad practice to have an upper bound on package versions and installers like pip do not typically consider development versions in any case (unless explicitly told to).

See: googleapis/google-api-python-client#2151
@con-f-use con-f-use mentioned this issue Jun 6, 2023
Merged
@con-f-use
Copy link
Contributor Author

Discussion in: googleapis/python-api-core#504

@con-f-use con-f-use mentioned this issue Jun 6, 2023
Closed
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 8, 2023
@con-f-use
fix: invalid dev version identifiers in setup.py (#1322)
a9b8f12 
Not ~PEP 440~ distlib compliant.

Fixes #1321
@release-please release-please bot mentioned this issue Jun 8, 2023
Merged
gcf-merge-on-green bot pushed a commit that referenced this issue Jun 13, 2023
@release-please
chore(main): release 2.20.0 (#1328)
36bba13 
🤖 I have created a release *beep* *boop*
---


## [2.20.0](https://togithub.com/googleapis/google-auth-library-python/compare/v2.19.1...v2.20.0) (2023-06-12)


### Features

* Add public API load_credentials_from_dict ([#1326](https://togithub.com/googleapis/google-auth-library-python/issues/1326)) ([5467ad7](https://togithub.com/googleapis/google-auth-library-python/commit/5467ad75334ee0b5e23522679171cda5fd4edb8a))


### Bug Fixes

* Expiry in compute_engine.IDTokenCredentials ([#1327](https://togithub.com/googleapis/google-auth-library-python/issues/1327)) ([56a6159](https://togithub.com/googleapis/google-auth-library-python/commit/56a6159444467717f5a5e3c04aa678bd0a5881da)), closes [#1323](https://togithub.com/googleapis/google-auth-library-python/issues/1323)
* Expiry in impersonated_credentials.IDTokenCredentials ([#1330](https://togithub.com/googleapis/google-auth-library-python/issues/1330)) ([d1b887c](https://togithub.com/googleapis/google-auth-library-python/commit/d1b887c4bebbe4ad0df6d8f7eb6a6d50355a135d))
* Invalid `dev` version identifiers in `setup.py` ([#1322](https://togithub.com/googleapis/google-auth-library-python/issues/1322)) ([a9b8f12](https://togithub.com/googleapis/google-auth-library-python/commit/a9b8f12db0c3ff4f84939646ba0777d21e68f572)), closes [#1321](https://togithub.com/googleapis/google-auth-library-python/issues/1321)

---
This PR was generated with [Release Please](https://togithub.com/googleapis/release-please). See [documentation](https://togithub.com/googleapis/release-please#release-please).
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
1 participant
@con-f-use