feat: universe domain support for service account #1286
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
BigTailWolf
approved these changes
May 8, 2023
clundin25
reviewed
May 9, 2023
clundin25
reviewed
May 9, 2023
clundin25
reviewed
May 9, 2023
clundin25
reviewed
May 9, 2023
clundin25
approved these changes
May 10, 2023
TimurSadykov
requested changes
May 10, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Support universe_domain field from service account json file. The default value is "googleapis.com".
If the value is not default, then
(1) for access token, we will always use self signed jwt flow. Note that domain wide delegation is not supported, so if subject is provided we will throw exceptions.
(2) for id token, we will always use iamcredentials.generateIdToken endpoint. Note that iam.serviceAccountTokenCreator role is required to call this endpoint.