Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: pin urllib3 < 2.0 to avoid breaking changes #1283

Merged
merged 2 commits into from
May 3, 2023

Conversation

BigTailWolf
Copy link
Contributor

@BigTailWolf BigTailWolf commented May 3, 2023

Urllib3 2.0 breaks google-auth because they removed urllib3.request.RequestMethods and made it private

@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@BigTailWolf BigTailWolf requested review from a team as code owners May 3, 2023 18:36
@BigTailWolf BigTailWolf added the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label May 3, 2023
@arithmetic1728 arithmetic1728 changed the title chore: update token chore: pin urllib3 < 2.0 to avoid breaking changes May 3, 2023
@arithmetic1728 arithmetic1728 merged commit 3c6a9de into googleapis:main May 3, 2023
12 checks passed
@tmct tmct mentioned this pull request Aug 3, 2023
markkuriekkinen added a commit to markkuriekkinen/a-plus that referenced this pull request Aug 23, 2023
The google-auth package, which is a dependency of the kubernetes package,
is not compatible with urllib3 2.0. Thus, require urllib3 < 2.0
to avoid conflicts with the dependencies.

googleapis/google-auth-library-python#1283
googleapis/google-auth-library-python#1365
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants