Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: pass thru OAuth audience during InstalledAppFlow.run_local_server #300

Merged
merged 2 commits into from
Aug 14, 2023

Conversation

keriwarr
Copy link
Contributor

@keriwarr keriwarr commented Aug 2, 2023

Thank you for opening a Pull Request! Before submitting your PR, there are a few things you can do to make sure it goes smoothly:

  • Make sure to open an issue as a bug/issue before writing your code! That way we can discuss the change, evaluate designs, and agree on the general idea
  • Ensure the tests and linter pass
  • Code coverage does not decrease (if any source code was changed)
    • coverage report has Missing 442->445, but I think it's talking about the docstring?
  • Appropriate docs were updated (if necessary)

Fixes #299 🦕 (context in issue)

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature.
@keriwarr keriwarr requested review from a team as code owners August 2, 2023 05:43
@google-cla
Copy link

google-cla bot commented Aug 2, 2023

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@product-auto-label product-auto-label bot added the size: m Pull request size is medium. label Aug 2, 2023
@keriwarr
Copy link
Contributor Author

keriwarr commented Aug 2, 2023

oh turns out my attempt to fill out the CLA failed because my organization has already signed one, I'll get myself added to the list

@keriwarr
Copy link
Contributor Author

keriwarr commented Aug 2, 2023

ok I think I've joined the CLA google group for my org

Copy link

@rseymour rseymour left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Not a code owner but this would be a great fix!

@keriwarr
Copy link
Contributor Author

@clundin25 what's the next step? can we get this approved?

@keriwarr
Copy link
Contributor Author

@clundin25 what's up with this "OwlBot Post Processor" status check?

@dandhlee dandhlee added the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2023
@gcf-owl-bot gcf-owl-bot bot removed the owlbot:run Add this label to trigger the Owlbot post processor. label Aug 14, 2023
@clundin25
Copy link
Contributor

@keriwarr It just needs to be manually triggered. It should pass with no problem

@dandhlee
Copy link
Contributor

OwlBot is our friendly bot for keeping things in sync with the rest of our googleapis/ repos. It usually doesn't run for external contributors and forks, I've kicked off the job manually :)

@clundin25
Copy link
Contributor

@keriwarr Can you confirm this code was needed so that the identity token had the correct audience?

@clundin25 clundin25 requested a review from sai-sunder-s August 14, 2023 18:42
@clundin25
Copy link
Contributor

I will merge after @sai-sunder-s has taken a look as well.

@keriwarr
Copy link
Contributor Author

@keriwarr Can you confirm this code was needed so that the identity token had the correct audience?

replied here: #299

@clundin25 clundin25 merged commit fe08531 into googleapis:main Aug 14, 2023
@clundin25
Copy link
Contributor

I will let this bake for a week and then cut a new release.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
size: m Pull request size is medium.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Feature Request: Ability to specify an OAuth audience to InstalledAppFlow.run_local_server
5 participants