fix: Use ordinal comparisons for string operations #2546
Merged
+117
−46
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
(Either through StringComparison.Ordinal or by the IndexOf(char) overload.)
jskeet
changed the title
jskeet
force-pushed
the
string-operations
branch
from
00fe278 to
3c085a0
Compare
|
Notes on changes I haven't made:
|
|
(I haven't added a test for every change. I suspect doing that would be too unwieldy as a long-term plan. Explicitly running all the tests in multiple cultures might not be a bad idea though.) |
amanda-tarafa
approved these changes
Sep 22, 2023
amanda-tarafa
added a commit
that referenced
this pull request
Sep 25, 2023
Bugs: * #2546 Which uses ordinal comparisons for string operations.
amanda-tarafa
added a commit
that referenced
this pull request
Sep 25, 2023
Bugs: * #2546 Which uses ordinal comparisons for string operations.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.