feat: Add extension method for progress interfaces to throw exceptions with better stack traces #2330
+257
−5
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Just thought: I could do the same for IDownloadProgress. Does that sound like a good plan? Can add another commit to the same PR. |
jskeet
force-pushed
the
better-exceptions
branch
from
93f370e to
7fb9320
Compare
…with a better stack trace
…n with a better stack trace
jskeet
force-pushed
the
better-exceptions
branch
from
7fb9320 to
3694418
Compare
jskeet
changed the title
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Feb 20, 2023
Features: - googleapis#2330 Improves exceptions thrown from progress interfaces.
amanda-tarafa
added a commit
that referenced
this pull request
Feb 20, 2023
Features: - #2330 Improves exceptions thrown from progress interfaces.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This will help us to diagnose googleapis/google-cloud-dotnet#8552 more easily.