feat: Improve error messages for JWT validation. #2046
Merged
+33
−18
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jskeet
approved these changes
Feb 8, 2022
| cachedCerts = new CachedCertificates( | ||
| JToken.Parse(certificatesJson)["keys"] | ||
| .AsEnumerable() | ||
| jwks |
There was a problem hiding this comment.
Unwrap the line below into this one?
There was a problem hiding this comment.
Yes, done, everything fit neetly in one line now. I'll push again and merge on green. Thanks!
In particular when certificates in a format other than JWK are used. Closes googleapis#2045
amanda-tarafa
force-pushed
the
token-validation-error
branch
from
aec6c78 to
e4221cf
Compare
amanda-tarafa
added a commit
to amanda-tarafa/google-api-dotnet-client
that referenced
this pull request
Feb 18, 2022
Bug fixes: - googleapis#1991. Disables self signed JWTs for domain-wide delegation. - googleapis#2023. Observes execeptions in refresh token tasks. Features: - googleapis#2037. Adds GoogleCredential.FromJsonParameters. - googleapis#2046. Improves error messages for JWT validation. Docs: - googleapis#2044. Adds links to OAuth2 docs in FAQs.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In particular when certificates in a format other than JWK are used.
Closes #2045