Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use a non-cloud type for nested unit test #270

Closed
Tracked by #113366
liggitt opened this issue May 18, 2023 · 0 comments · Fixed by #276
Closed
Tracked by #113366

Use a non-cloud type for nested unit test #270

liggitt opened this issue May 18, 2023 · 0 comments · Fixed by #276
Assignees
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.

Comments

@liggitt
Copy link
Contributor

liggitt commented May 18, 2023

It looks like #170 added a reference to google.golang.org/genproto/googleapis/longrunning which is an alias of cloud types. Is there an alternative non-cloud type that could be used for the "nested" test case at https://github.com/googleapis/gax-go/blob/main/v2/proto_json_stream_test.go#L78-L82?

Context:

cc @quartzmo @noahdietz

@liggitt liggitt added priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design. labels May 18, 2023
@quartzmo quartzmo assigned quartzmo and unassigned quartzmo May 19, 2023
@noahdietz noahdietz self-assigned this May 23, 2023
gcf-merge-on-green bot pushed a commit that referenced this issue May 23, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
priority: p3 Desirable enhancement or fix. May not be included in next release. type: feature request ‘Nice-to-have’ improvement, new feature or different behavior or design.
Projects
None yet
Development

Successfully merging a pull request may close this issue.

3 participants