Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: remove legacy list revisions rules #1348

Merged
merged 1 commit into from Feb 29, 2024

Conversation

noahdietz
Copy link
Collaborator

@noahdietz noahdietz commented Feb 29, 2024

With AIP-162 moving towards a new design that is incompatible with the previous (known as "legacy" from here on), the same rules for List Revisions APIs no longer apply, and directly conflict with Standard List APIs. All of the legacy list revisions rules are deleted.

Now, instead of excluding List{Resource}Revisions methods from the scope of Standard List methods, we will exclude legacy list revision methods from the scope of Standard List. Legacy methods are identified as follows:

  • having a method name Like List{Resource}Revisions
  • having a string name field instead of string parent
  • having the :listRevisions HTTP uri suffix

Note: If the RPC does not have a google.api.http binding to check for the suffix, fulfilling the first two aspects will be sufficient to identify a legacy method.

This means that all "new" list revisions methods will adhere to Standard List structure AIP-132.

Addresses internal bug

@noahdietz noahdietz merged commit 2bc5c57 into googleapis:main Feb 29, 2024
6 checks passed
@noahdietz noahdietz deleted the remove-list-revisions branch February 29, 2024 21:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants