Add non-slice Ref constructors w/ slice elem count #996
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
known-layout-metadata
branch
from
9c18f87
to
304f572
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
0174c86
to
42b90d8
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
304f572
to
b730441
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
42b90d8
to
e24c207
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
b730441
to
ef75344
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
e24c207
to
b0f308f
Compare
jswrenn
force-pushed
the
known-layout-ref-apis
branch
from
b0f308f
to
c4dce00
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
ef75344
to
6100500
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
c4dce00
to
ab25c82
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
6100500
to
abe69ee
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
ab25c82
to
17038c6
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
abe69ee
to
ef40641
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
17038c6
to
434d90e
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
ef40641
to
fe63e38
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
2 times, most recently
from
b139992
to
a6e01bd
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
fe63e38
to
435feb4
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
2 times, most recently
from
d26bb4d
to
2321483
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
2321483
to
32eb523
Compare
joshlf
force-pushed
the
known-layout-ref-apis
branch
2 times, most recently
from
665a1dd
to
f7788ed
Compare
jswrenn
approved these changes
Apr 24, 2024
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to failed status checks
github-merge-queue
bot
removed this pull request from the merge queue due to a conflict with the base branch
Add `Ref` constructors which are generic over `T: KnownLayout<PointerMetadata = usize>` - in other words, types whose trailing field is a slice (i.e., slices or slice DSTs). These constructors take an explicit element count for the trailing slice, and replace the previous constructors which only supported slices. Makes progress on #29
joshlf
force-pushed
the
known-layout-ref-apis
branch
from
f7788ed
to
0cfe603
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add
Refconstructors which are generic overT: KnownLayout<PointerMetadata = usize>- in other words, types whose trailing field is a slice (i.e., slices or slice DSTs). These constructors take an explicit element count for the trailing slice, and replace the previous constructors which only supported slices.Makes progress on #29