KnownLayout tracks pointer metadata type #995
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
known-layout-metadata
branch
3 times, most recently
from
9c18f87
to
304f572
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
304f572
to
b730441
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
b730441
to
ef75344
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
3 times, most recently
from
abe69ee
to
ef40641
Compare
joshlf
force-pushed
the
known-layout-metadata
branch
from
ef40641
to
fe63e38
Compare
jswrenn
requested changes
Apr 23, 2024
Comment on lines
+1068
to
+1070
| /// `()` for sized types and `usize` for slice DSTs. | ||
| #[doc(hidden)] | ||
| type PointerMetadata: PointerMetadata; |
There was a problem hiding this comment.
Might want to remove the doc(hidden) here once this appears in where bounds.
src/lib.rs
Outdated
Comment on lines
1091
to
1092
| /// What is the size of the object with the given layout and pointer | ||
| /// metadata? |
There was a problem hiding this comment.
Suggested change
| /// What is the size of the object with the given layout and pointer | |
| /// metadata? | |
| /// Computes the size of the object with the given layout and pointer | |
| /// metadata. |
src/lib.rs
Outdated
| fn size_for_metadata(&self, layout: DstLayout) -> Option<usize> { | ||
| match layout.size_info { | ||
| SizeInfo::Sized { size } => Some(size), | ||
| SizeInfo::SliceDst(_) => unreachable!(), |
There was a problem hiding this comment.
In the interest of minimizing our panic paths, perhaps we should do something besides unreachable!(), like return None.
(We can't use unreachable_unchecked(), because this method is safe and this line is obviously not actually unreachable when evaluated in isolation.)
Makes progress on #29
joshlf
force-pushed
the
known-layout-metadata
branch
from
fe63e38
to
435feb4
Compare
jswrenn
approved these changes
Apr 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Makes progress on #29