Implement more complete fix for #716 #758
Labels
compatibility-breaking
Changes that are (likely to be) breaking
Comments
This was referenced Dec 28, 2023
Open
joshlf
added a commit
that referenced
this issue
Feb 29, 2024
Add `IntoByteSlice` and `IntoByteSliceMut` traits, which extend `ByteSlice` and `ByteSliceMut`, adding `Into<&[u8]>` and `Into<&mut [u8]>` bounds respectively. Use these new traits as the bounds in the `Ref` methods `into_ref`, `into_mut`, `into_slice`, and `into_mut_slice`. This allows us to remove the post-monomorphization error which was originally added to patch the soundness hole in #716 in a backwards-compatible way. Closes #758
joshlf
added a commit
that referenced
this issue
Feb 29, 2024
Add `IntoByteSlice` and `IntoByteSliceMut` traits, which extend `ByteSlice` and `ByteSliceMut`, adding `Into<&[u8]>` and `Into<&mut [u8]>` bounds respectively. Use these new traits as the bounds in the `Ref` methods `into_ref`, `into_mut`, `into_slice`, and `into_mut_slice`. This allows us to remove the post-monomorphization error which was originally added to patch the soundness hole in #716 in a backwards-compatible way. Closes #758
github-merge-queue bot
pushed a commit
that referenced
this issue
Feb 29, 2024
Add `IntoByteSlice` and `IntoByteSliceMut` traits, which extend `ByteSlice` and `ByteSliceMut`, adding `Into<&[u8]>` and `Into<&mut [u8]>` bounds respectively. Use these new traits as the bounds in the `Ref` methods `into_ref`, `into_mut`, `into_slice`, and `into_mut_slice`. This allows us to remove the post-monomorphization error which was originally added to patch the soundness hole in #716 in a backwards-compatible way. Closes #758
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
The fix implemented for #716 patches the soundness hole, but results in an API which doesn't properly express the type bounds for when it is sound to call
Ref::into_ref,into_mut,into_slice, andinto_mut_slice. We should restructure the API so that these methods fail to compile when used with unsound types (core::cell::Refandcore::cell::RefMut), but compile successfully when used with sound types. This will be a breaking change.The text was updated successfully, but these errors were encountered: