-
Notifications
You must be signed in to change notification settings - Fork 73
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add slice-based methods to FromBytes #593
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for this!
b0c139a
to
29e15d7
Compare
Done! I've used |
Oops, just saw this. Yeah, that'd be preferable, thanks! |
29e15d7
to
8434716
Compare
Okay, looks good! Could you update |
8434716
to
236ccd6
Compare
236ccd6
to
8459e69
Compare
Done! |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sweet, thanks!
Right now slice conversion methods are somewhat buried in
Ref
. For better ergonomics and discoverability I think it's worth to have the slice-based methods on theFromBytes
trait.