Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[macro_util] Add comment to core_reexport #586

Merged
merged 2 commits into from
Nov 3, 2023
Merged

[macro_util] Add comment to core_reexport #586

merged 2 commits into from
Nov 3, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Nov 2, 2023

Add a comment explaining why we don't change core_reexport to pub use core as core_reexport.

@joshlf
[macro_util] Add comment to core_reexport
0c33b98 
Add a comment explaining why we don't change core_reexport
to `pub use core as core_reexport`.
@joshlf joshlf requested a review from jswrenn November 2, 2023 13:06
@joshlf joshlf mentioned this pull request Nov 2, 2023
Closed
@joshlf joshlf enabled auto-merge November 2, 2023 13:07
jswrenn
jswrenn requested changes Nov 3, 2023
View reviewed changes
Copy link
Collaborator

@jswrenn jswrenn left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nit: We don't need to release a semver-breaking version, we merely need to bump the version in our Cargo.toml to 0.8 in main.

@joshlf joshlf requested a review from jswrenn November 3, 2023 14:47
@joshlf
Copy link
Member Author

joshlf commented Nov 3, 2023

Nit: We don't need to release a semver-breaking version, we merely need to bump the version in our Cargo.toml to 0.8 in main.

Done.

@joshlf joshlf added this pull request to the merge queue Nov 3, 2023
Merged via the queue into main with commit c9772d9 Nov 3, 2023
126 checks passed
@joshlf joshlf deleted the macro-use-comment branch November 3, 2023 15:05
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jswrenn jswrenn jswrenn approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@joshlf @jswrenn