Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[byteorder] Implement core::ops traits #434

Merged
merged 1 commit into from Oct 2, 2023
Merged

[byteorder] Implement core::ops traits #434

merged 1 commit into from Oct 2, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Sep 30, 2023

Release 0.7.6

@joshlf joshlf marked this pull request as draft September 30, 2023 01:14
@joshlf joshlf force-pushed the byteorder-traits branch 2 times, most recently from 9938747 to 84cda6a Compare October 2, 2023 00:50
@joshlf joshlf marked this pull request as ready for review October 2, 2023 00:51
@joshlf joshlf requested a review from jswrenn October 2, 2023 00:51
@joshlf
Copy link
Member Author

joshlf commented Oct 2, 2023

Not sure whether the added test will pass Kani; I tried locally, and it hung for a long time and I eventually gave up. It's a very simple test, so I'm not worried about its correctness; if Kani can't handle it, I'll just disable Kani on that test rather than try to refactor the test to get it to work.

@joshlf
Copy link
Member Author

joshlf commented Oct 2, 2023

Not sure whether the added test will pass Kani; I tried locally, and it hung for a long time and I eventually gave up. It's a very simple test, so I'm not worried about its correctness; if Kani can't handle it, I'll just disable Kani on that test rather than try to refactor the test to get it to work.

Kani wasn't able to complete the proof after 6 hours, so I've disabled it on test_ops_implss.

jswrenn
jswrenn previously approved these changes Oct 2, 2023
src/byteorder.rs Outdated Show resolved Hide resolved
@joshlf joshlf enabled auto-merge October 2, 2023 20:50
@joshlf joshlf added this pull request to the merge queue Oct 2, 2023
Merged via the queue into main with commit 808ad38 Oct 2, 2023
152 checks passed
@joshlf joshlf deleted the byteorder-traits branch October 2, 2023 21:02
@joshlf joshlf mentioned this pull request Oct 3, 2023
4 tasks
samuelselleck pushed a commit to samuelselleck/zerocopy that referenced this pull request Oct 13, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants