[ci] Roll pinned nightly toolchain automatically #408
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
roll-nightly-github-action
branch
7 times, most recently
from
214f020
to
6504d1c
Compare
joshlf
force-pushed
the
roll-nightly-github-action
branch
12 times, most recently
from
62581c1
to
b19affc
Compare
joshlf
force-pushed
the
roll-nightly-github-action
branch
3 times, most recently
from
3509cf2
to
bcae814
Compare
joshlf
commented
Sep 21, 2023
joshlf
force-pushed
the
roll-nightly-github-action
branch
from
bcae814
to
e5c6363
Compare
|
@jswrenn This is ready for review mod outstanding comments, which are minor and mechanical. If you approve, I'll only make changes as described in those comments. |
joshlf
force-pushed
the
roll-nightly-github-action
branch
3 times, most recently
from
2a08ba5
to
097698b
Compare
joshlf
force-pushed
the
roll-nightly-github-action
branch
2 times, most recently
from
4e279bc
to
15ad251
Compare
joshlf
force-pushed
the
roll-nightly-github-action
branch
from
15ad251
to
b652457
Compare
jswrenn
approved these changes
Sep 27, 2023
| name: Roll pinned toolchain versions | ||
| on: | ||
| schedule: | ||
| - cron: '29 12 * * *' |
There was a problem hiding this comment.
What's the rationale for running this at 12:29? Seems like an oddly specific time, so if there's a rationale here, I'd be curious to hear it.
There was a problem hiding this comment.
Partially copy-pasted from another file. The 12 (UTC) is chosen so it runs in the middle of the night for those in the US and produces PRs which have already run through CI by the morning.
Comment on lines
+54
to
+75
| function update-pinned-version { | ||
| VERSION_NAME="$1" | ||
| VERSION="$2" | ||
| # For nightly, this is the same as `$VERSION`. For stable, it's | ||
| # `stable` because `rustup` doesn't recognize that `x.y.z` refers to | ||
| # the same thing as `stable` even if they're the same toolchain. | ||
| VERSION_FOR_CARGO="$3" | ||
| ZEROCOPY_FEATURES="$4" | ||
|
|
||
| # Confirm that `Cargo.toml` lists the pinned version in the expected | ||
| # format. This is a prerequisite for the subsequent `sed` command. | ||
| REGEX="^pinned-$VERSION_NAME = \"[a-z0-9\.-]*\"$" | ||
| validate-file "$REGEX" Cargo.toml | ||
| sed -i -e "s/$REGEX/pinned-$VERSION_NAME = \"$VERSION\"/" Cargo.toml | ||
|
|
||
| # Confirm that the update didn't bork `Cargo.toml`. | ||
| validate-file "$REGEX" Cargo.toml | ||
|
|
||
| # Update `.stderr` files as needed for the new version. | ||
| TRYBUILD=overwrite cargo "+$VERSION_FOR_CARGO" test --package zerocopy $ZEROCOPY_FEATURES | ||
| TRYBUILD=overwrite cargo "+$VERSION_FOR_CARGO" test --package zerocopy-derive | ||
| } |
There was a problem hiding this comment.
Once the cargo script work is stabilized, it might be a tad more robust to use toml_edit for this.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Rolling nightly toolchain works. Blocked on #412 in order to support rolling stable toolchain.