Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[cargo.sh] Initial commit #363

Merged
merged 1 commit into from
Sep 10, 2023
Merged

[cargo.sh] Initial commit #363

merged 1 commit into from
Sep 10, 2023

Conversation

joshlf
Copy link
Member

@joshlf joshlf commented Sep 10, 2023

cargo.sh is a small utility that supports running Cargo with human-readable toolchain names that are mapped to the equivalent versions pinned in CI. It supports "msrv", "stable", and "nightly". It also supports a meta-toolchain, "all", which instructs it to run a command once with each of the three pinned toolchains.

In this commit, we replace the toolchain name-to-version resolution logic in CI with this command. This simplifies our CI configuration, and maintains the property that the code run in CI is the same code a developer would run on their local machine.

cc @djkoloski

@joshlf joshlf force-pushed the cargo-sh branch 2 times, most recently from 0a82267 to 368f200 Compare September 10, 2023 08:22
@joshlf joshlf requested a review from jswrenn September 10, 2023 15:35
@joshlf joshlf force-pushed the cargo-sh branch 2 times, most recently from a32327f to f4b00e8 Compare September 10, 2023 16:19
`cargo.sh` is a small utility that supports running Cargo with
human-readable toolchain names that are mapped to the equivalent
versions pinned in CI. It supports "msrv", "stable", and "nightly". It
also supports a meta-toolchain, "all", which instructs it to run a
command once with each of the three pinned toolchains.

In this commit, we replace the toolchain name-to-version resolution
logic in CI with this command. This simplifies our CI configuration, and
maintains the property that the code run in CI is the same code a
developer would run on their local machine.
@joshlf joshlf removed the request for review from jswrenn September 10, 2023 16:38
@joshlf joshlf merged commit 311e662 into main Sep 10, 2023
150 checks passed
@joshlf joshlf deleted the cargo-sh branch September 10, 2023 16:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

1 participant