Impl traits for TransparentWrapper types safely #1001
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
joshlf
force-pushed
the
transparent-wrapper-trait-impls
branch
3 times, most recently
from
12b26e6
to
699046b
Compare
`TransparentWrapper` provides enough safety guarantees that, for some traits, it can be used as a bound to implement those traits without needing extra safety logic. This commit introduces the `impl_for_transparent_wrapper!` macro, which emits the appropriate bound on `TransparentWrapper` in order to justify the soundness of a given trait impl internally, thus not requiring the caller to provide a safety proof.
joshlf
force-pushed
the
transparent-wrapper-trait-impls
branch
from
699046b
to
5c026a0
Compare
jswrenn
approved these changes
Mar 3, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TransparentWrapperprovides enough safety guarantees that, for some traits, it can be used as a bound to implement those traits without needing extra safety logic.This commit introduces the
impl_for_transparent_wrapper!macro, which emits the appropriate bound onTransparentWrapperin order to justify the soundness of a given trait impl internally, thus not requiring the caller to provide a safety proof.