Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Bump golangci-lint and remove //nolint comments in experimental/batchmap/cmd/verify/verify.go #2801

Open
AlCutter opened this issue Aug 18, 2022 · 0 comments
Labels

Comments

@AlCutter
Copy link
Member

#2787 migrated Trillian to use klog. At the time, golangci-lint's staticcheck did not know that klog.Exit/Fatal would not return and so threw false +ve lint checks during presubmit which were suppressed with nolint comments.

A fix has been sent which enlightens the lint checker, so once that fix has made it into a golangci-lint release (v1.48.0 did not contain it) we should bump the version used in our presubmits and remove the //nolint comments in experimental/batchmap/cmd/verify/verify.go

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

1 participant