Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

strip out unused and unneeded code #2245

Open
pphaneuf opened this issue Oct 23, 2020 · 0 comments
Open

strip out unused and unneeded code #2245

pphaneuf opened this issue Oct 23, 2020 · 0 comments
Labels

Comments

@pphaneuf
Copy link
Contributor

A number of APIs (both external and internal) add burden to storage implementers, without bringing much benefits.

For example, QueueLeaves is complex to implement correctly, due to being a batching API with partial failure, but in practice, there are possibly no need for it, and due to the implementation complexity, is very unlikely to provide any performance benefit over using QueueLeaf (the non-batch version of this API) multiple times (potentially concurrently), say, and this both leaves the user in better control over what happens in the partial failure cases, and removes complexity of implementation (and the inevitable bugs that it brings).

@pphaneuf pphaneuf self-assigned this Oct 23, 2020
pphaneuf added a commit that referenced this issue Oct 23, 2020
pphaneuf added a commit that referenced this issue Mar 22, 2021
pphaneuf added a commit that referenced this issue Mar 23, 2021
pphaneuf added a commit that referenced this issue Mar 23, 2021
pphaneuf added a commit that referenced this issue Mar 23, 2021
There's only one hasher to register, as a first step, simply verify that
it is the hasher requested, and return it.

Part of #2245.
pphaneuf added a commit that referenced this issue Mar 23, 2021
pphaneuf added a commit that referenced this issue Mar 24, 2021
pphaneuf added a commit that referenced this issue Mar 30, 2021
pphaneuf added a commit that referenced this issue Apr 6, 2021
* Do not have the signer fill out the KeyHint field.

Part of #2245.

* Remove the KeyHint field.

Part of #2245.

* Remove SerializeKeyHint and ParseKeyHint.

Part of #2245.
pphaneuf added a commit that referenced this issue Apr 9, 2021
pphaneuf added a commit that referenced this issue Apr 9, 2021
pphaneuf added a commit that referenced this issue Apr 9, 2021
pphaneuf added a commit that referenced this issue May 18, 2021
pphaneuf added a commit that referenced this issue May 19, 2021
@pphaneuf pphaneuf removed their assignment Aug 20, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

No branches or pull requests

2 participants