Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove flags (s2a_timeout, s2a_enable_appengine_dialer) #107

Closed
howardjohn opened this issue Apr 28, 2023 · 2 comments
Closed

Remove flags (s2a_timeout, s2a_enable_appengine_dialer) #107

howardjohn opened this issue Apr 28, 2023 · 2 comments

Comments

@howardjohn
Copy link

These flags are registered by any binary that imports this library as they are registered in init(). This in turn means they should up in our binaries. This is unexpected for users.

While I couldn't find anything official recommending not to do that, looking at our entire dependency tree, which is quite large, this is the only library that does this. This leads me to believe that using flags in libraries (as opposed to binaries) is not a very established pattern in the ecosystem.

@xmenxk
Copy link
Collaborator

xmenxk commented May 17, 2023

thanks for reporting, I'm taking a look

@xmenxk
Copy link
Collaborator

xmenxk commented May 19, 2023

updating google-api-go-client dependency in googleapis/google-api-go-client#1989

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants