Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support PEP 742 (TypeIs) #1588

Closed
JelleZijlstra opened this issue Feb 19, 2024 · 2 comments
Closed

Support PEP 742 (TypeIs) #1588

JelleZijlstra opened this issue Feb 19, 2024 · 2 comments
Assignees
@rchen152
Labels
cat: control flow control flow analysis enhancement

Comments

@JelleZijlstra
Copy link
Contributor

Please add support for the TypeIs special form from PEP 742. Pytype support would help enable us to use the new feature in typeshed.

I am willing to work on this myself, but I might need some help getting the tests to run; when I last tried to build pytype locally, CMake didn't work.
@JelleZijlstra JelleZijlstra mentioned this issue Feb 19, 2024
Closed
6 tasks
@rchen152 rchen152 added enhancement cat: control flow control flow analysis labels Feb 20, 2024
@rchen152 rchen152 self-assigned this Feb 20, 2024
@rchen152
Copy link
Contributor

I'll work on this.

@JelleZijlstra
Copy link
Contributor Author

Thanks! I already implemented it in both mypy and pyanalyze and it was pretty easy to do, essentially combining the mechanics of TypeGuard with the narrowing semantics of isinstance(). My mypy PR has a set of test cases that may be useful: python/mypy#16898

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees

@rchen152 rchen152

Labels
cat: control flow control flow analysis enhancement
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
2 participants
@JelleZijlstra @rchen152