.github/workflows/ci.yaml

@@ -18,7 +18,7 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: ['1.20', '1.21', 'tip']
+        go: ['1.22', '1.23', 'tip']
         # Supported macOS versions can be found in
         # https://github.com/actions/virtual-environments#available-environments.
         # TODO: Add macos-13. As of now there are build errors when installing graphviz.
@@ -28,11 +28,31 @@ jobs:
         # - https://github.com/actions/virtual-environments/blob/main/images/macos/macos-13-Readme.md#xcode
         xcode-version: ['14.2', '14.1', '14.0.1', '13.4.1', '13.3.1', '13.2.1', '13.1']
     steps:
+      - name: Checkout the repo
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          path: ${{ env.WORKING_DIR }}
+
       - name: Update Go version using setup-go
-        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
         if: matrix.go != 'tip'
         with:
+          # Include cache directives to allow proper caching. Without them, we
+          # get setup-go "Restore cache failed" warnings.
           go-version: ${{ matrix.go }}
+          cache: true
+          cache-dependency-path: '**/go.sum'
+
+      - name: Install Go bootstrap compiler
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        if: matrix.go == 'tip'
+        with:
+          # Bootstrapping go tip requires 1.22.6
+          # Include cache directives to allow proper caching. Without them, we
+          # get setup-go "Restore cache failed" warnings.
+          go-version: 1.22
+          cache: true
+          cache-dependency-path: '**/go.sum'
 
       - name: Update Go version manually
         if: matrix.go == 'tip'
@@ -46,11 +66,6 @@ jobs:
           echo "RUN_GOLANGCI_LINTER=false" >> $GITHUB_ENV
           echo "$HOME/gotip/bin:$PATH" >> $GITHUB_PATH
 
-      - name: Checkout the repo
-        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
-        with:
-          path: ${{ env.WORKING_DIR }}
-
       - name: Set up Xcode
         uses: maxim-lobanov/setup-xcode@60606e260d2fc5762a71e64e74b2174e8ea3c8bd # v1.6.0
         with:
@@ -61,8 +76,8 @@ jobs:
           brew install graphviz
           # Do not let tools interfere with the main module's go.mod.
           cd && go mod init tools
-          go install honnef.co/go/tools/cmd/staticcheck@v0.4.6
-          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0
+          go install honnef.co/go/tools/cmd/staticcheck@v0.5.1
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3
           # Add PATH for installed tools.
           echo "$GOPATH/bin:$PATH" >> $GITHUB_PATH
 
@@ -72,7 +87,7 @@ jobs:
           ./test.sh
 
       - name: Code coverage
-        uses: codecov/codecov-action@5ecb98a3c6b747ed38dc09f787459979aebb39be # v4.3.1
+        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4.6.0
         with:
           file: ${{ env.WORKING_DIR }}/coverage.txt
 
@@ -84,14 +99,34 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: ['1.20', '1.21', 'tip']
+        go: ['1.22', '1.23', 'tip']
         os: ['ubuntu-22.04', 'ubuntu-20.04']
     steps:
+      - name: Checkout the repo
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
+        with:
+          path: ${{ env.WORKING_DIR }}
+
       - name: Update Go version using setup-go
-        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
         if: matrix.go != 'tip'
         with:
+          # Include cache directives to allow proper caching. Without them, we
+          # get setup-go "Restore cache failed" warnings.
           go-version: ${{ matrix.go }}
+          cache: true
+          cache-dependency-path: '**/go.sum'
+
+      - name: Install Go bootstrap compiler
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        if: matrix.go == 'tip'
+        with:
+          # Bootstrapping go tip requires 1.22.6
+          # Include cache directives to allow proper caching. Without them, we
+          # get setup-go "Restore cache failed" warnings.
+          go-version: 1.22
+          cache: true
+          cache-dependency-path: '**/go.sum'
 
       - name: Update Go version manually
         if: matrix.go == 'tip'
@@ -105,32 +140,48 @@ jobs:
           echo "RUN_GOLANGCI_LINTER=false" >> $GITHUB_ENV
           echo "$HOME/gotip/bin" >> $GITHUB_PATH
 
-      - name: Checkout the repo
-        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
-        with:
-          path: ${{ env.WORKING_DIR }}
-
       - name: Check chrome for browser tests
         run: |
           google-chrome --version
 
+      - name: Add LLVM 14.0 repository to ensure llvm-symbolizer 14.0.0+ on Ubuntu 20.04
+        if: matrix.os == 'ubuntu-20.04'
+        run: |
+          wget -O - https://apt.llvm.org/llvm-snapshot.gpg.key | sudo apt-key add -
+          sudo add-apt-repository "deb http://apt.llvm.org/focal/ llvm-toolchain-focal-14 main"
+          sudo apt-get update
+
+      - name: Install llvm-symbolizer
+        run: |
+          if [ "${{ matrix.os }}" = "ubuntu-20.04" ]; then
+            sudo apt-get install -y llvm-14 clang-14
+            sudo update-alternatives --install /usr/bin/llvm-symbolizer llvm-symbolizer /usr/bin/llvm-symbolizer-14 100
+          else
+            sudo apt-get update
+            sudo apt-get install -y llvm clang
+          fi
+
       - name: Fetch dependencies
         run: |
           sudo apt-get install graphviz
           # Do not let tools interfere with the main module's go.mod.
           cd && go mod init tools
-          go install honnef.co/go/tools/cmd/staticcheck@v0.4.6
-          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.51.0
+          go install honnef.co/go/tools/cmd/staticcheck@v0.5.1
+          go install github.com/golangci/golangci-lint/cmd/golangci-lint@v1.60.3
           # Add PATH for installed tools.
           echo "$GOPATH/bin:$PATH" >> $GITHUB_PATH
 
+      - name: Check llvm-symbolizer installation
+        run: |
+          llvm-symbolizer --version
+
       - name: Run the script
         run: |
           go version
           ./test.sh
 
       - name: Code coverage
-        uses: codecov/codecov-action@5ecb98a3c6b747ed38dc09f787459979aebb39be # v4.3.1
+        uses: codecov/codecov-action@b9fd7d16f6d7d1b5d2bec1a2887e65ceed900238 # v4.6.0
         with:
           file: ${{ env.WORKING_DIR }}/coverage.txt
 
@@ -139,18 +190,22 @@ jobs:
     strategy:
       fail-fast: false
       matrix:
-        go: ['1.20', '1.21']
+        go: ['1.22', '1.23']
     steps:
-      - name: Update Go version using setup-go
-        uses: actions/setup-go@cdcb36043654635271a94b9a6d1392de5bb323a7 # v5.0.1
-        with:
-          go-version: ${{ matrix.go }}
-
       - name: Checkout the repo
-        uses: actions/checkout@a5ac7e51b41094c92402da3b24376905380afc29 # v4.1.6
+        uses: actions/checkout@11bd71901bbe5b1630ceea73d27597364c9af683 # v4.2.2
         with:
           path: ${{ env.WORKING_DIR }}
 
+      - name: Update Go version using setup-go
+        uses: actions/setup-go@41dfa10bad2bb2ae585af6ee5bb4d7d973ad74ed # v5.1.0
+        with:
+          # Include cache directives to allow proper caching. Without them, we
+          # get setup-go "Restore cache failed" warnings.
+          go-version: ${{ matrix.go }}
+          cache: true
+          cache-dependency-path: '**/go.sum'
+
       - name: Fetch Windows dependency
         uses: crazy-max/ghaction-chocolatey@0e015857dd851f84fcb7fb53380eb5c4c8202333 # v3.0.0
         with:

.gitignore

@@ -6,5 +6,3 @@
 core
 coverage.txt
 pprof
-third_party/d3flamegraph/d3.js
-third_party/d3flamegraph/node_modules

browsertests/go.mod

@@ -1,6 +1,6 @@
 module github.com/google/pprof/browsertests
 
-go 1.19
+go 1.22
 
 // Use the version of pprof in this directory tree.
 replace github.com/google/pprof => ../

browsertests/testdata/testfixture.js

@@ -1,6 +1,6 @@
 // TestFixture records log messages and errors in an array that will
 // be returned to Go code. Each element in the result array is either
-// an array of the form ["LOG", ...]", or ["ERROR", ...].
+// an array of the form ["LOG", ...], or ["ERROR", ...].
 class TestFixture {
   constructor() {
     this.context = "";  // Added to front of all log and error messages.

driver/driver.go

@@ -186,10 +186,11 @@ type ObjFile interface {
 
 // A Frame describes a single line in a source file.
 type Frame struct {
-	Func   string // name of function
-	File   string // source file name
-	Line   int    // line in file
-	Column int    // column in file
+	Func      string // name of function
+	File      string // source file name
+	Line      int    // line in file
+	Column    int    // column in file
+	StartLine int    // start line of function (if available)
 }
 
 // A Sym describes a single symbol in an object file.

go.mod

@@ -1,6 +1,6 @@
 module github.com/google/pprof
 
-go 1.19
+go 1.22
 
 require (
 	github.com/chzyer/readline v1.5.1