refactor: apply Rubocop to Ruby generator #956
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
changed the title
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #956 +/- ##
=======================================
Coverage 63.67% 63.67%
=======================================
Files 146 146
Lines 11960 11960
=======================================
Hits 7616 7616
Misses 3878 3878
Partials 466 466 ☔ View full report in Codecov by Sentry. |
G-Rath
requested review from
another-rex,
cuixq,
hogo6002 and
josieang
and removed request for
josieang
G-Rath
force-pushed
the
generators/apply-rubocop
branch
from
1b38176
to
46442d0
Compare
oliverchang
approved these changes
May 3, 2024
josieang
pushed a commit
to josieang/osv-scanner
that referenced
this pull request
Jun 6, 2024
Cherry-pick of G-Rath/osv-detector#240 --- This is all pretty harmless but there's some nice small improvements in here
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Cherry-pick of G-Rath/osv-detector#240
This is all pretty harmless but there's some nice small improvements in here