feat: support comparing Alpine versions locally #980
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
G-Rath
force-pushed
the
semantic/support-alpine
branch
from
acee4d9
to
fc9938b
Compare
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #980 +/- ##
==========================================
+ Coverage 64.47% 64.97% +0.49%
==========================================
Files 148 149 +1
Lines 12088 12257 +169
==========================================
+ Hits 7794 7964 +170
+ Misses 3843 3842 -1
Partials 451 451 ☔ View full report in Codecov by Sentry. |
G-Rath
force-pushed
the
semantic/support-alpine
branch
from
e2e73ba
to
68411e6
Compare
another-rex
reviewed
May 24, 2024
G-Rath
force-pushed
the
semantic/support-alpine
branch
from
68411e6
to
4a2fdc5
Compare
…ce in the string is equal to 0
… doesn't seem to matter
G-Rath
force-pushed
the
semantic/support-alpine
branch
from
99c08d5
to
03a4545
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This introduces support for comparing Alpine versions locally using the same logic as the
apkpackage manager, along with a generator for generating fixtures.There is a bit of fuzziness in the behaviour across different versions of
apk- thealpine:3.xdocker images all useapkv2.x, which is what the fixture generator uses too and at leastapkv2.14 (which is used byalpine:3.19) and v2.10 pass; however the current latest upcoming version ofapktechnically fails on approximately 30 fixtures which I think is because it has fixed https://gitlab.alpinelinux.org/alpine/abuild/-/issues/10088.Beyond that I was able to find a handful of other edge cases where the comparison results between these versions was different, but they all seemed to be primarily around the handling of invalid versions which are not expected to be present in OSV data anyway and they look to be the result of bugfixes meaning we'd need special "anti" handling to support in a way that ensures valid versions are still compared correctly, so I think it's good enough to ship.
Resolves #952