Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Align GoVulncheck Go version with go.mod #818

Merged
merged 6 commits into from
Feb 26, 2024

Conversation

hogo6002
Copy link
Contributor

@hogo6002 hogo6002 commented Feb 22, 2024

GoVulncheck uses local installed GO version to determine vulnerabilities if the env GOVERSION is not defined.
Set the GOVERSION value to the one defined in go.mod.

detail: #679

@codecov-commenter
Copy link

codecov-commenter commented Feb 22, 2024

Codecov Report

Attention: Patch coverage is 25.00000% with 6 lines in your changes are missing coverage. Please review.

Project coverage is 59.46%. Comparing base (ef3a2a4) to head (f71da79).
Report is 6 commits behind head on main.

Files Patch % Lines
internal/sourceanalysis/go.go 25.00% 6 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff             @@
##             main     #818       +/-   ##
===========================================
- Coverage   71.79%   59.46%   -12.33%     
===========================================
  Files         118      136       +18     
  Lines        8677    11162     +2485     
===========================================
+ Hits         6230     6638      +408     
- Misses       2078     4099     +2021     
- Partials      369      425       +56     

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@oliverchang oliverchang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Is there a test we can add for this?

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some comments

pkg/osvscanner/osvscanner.go Outdated Show resolved Hide resolved
internal/sourceanalysis/go.go Outdated Show resolved Hide resolved
Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, thanks!

internal/sourceanalysis/go.go Show resolved Hide resolved
Co-authored-by: Rex P <106129829+another-rex@users.noreply.github.com>
@hogo6002 hogo6002 merged commit 63d8b2a into google:main Feb 26, 2024
11 checks passed
spencerschrock added a commit to spencerschrock/scorecard that referenced this pull request Mar 6, 2024
see google/osv-scanner#818 for details

Signed-off-by: Spencer Schrock <sschrock@google.com>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

5 participants