Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix(javareach): maven validation and correct manifest class name parsing #1708

Merged
merged 3 commits into from
Mar 13, 2025

Conversation

hogo6002
Copy link
Contributor

Fixes a bunch of Java readability issues:

  • remove com/ from stdlib prefixes
  • exit program with errors if running against a non maven JAR
  • handle wrapped class names in the manifest file
  • replace some non-fatel error messages with debug messages to reduce noise

@hogo6002 hogo6002 requested a review from oliverchang March 13, 2025 04:29
@hogo6002 hogo6002 changed the title fix(javareach): maven validation and manifest handling fix(javareach): maven validation and correct manifest class name parsing Mar 13, 2025
@codecov-commenter
Copy link

codecov-commenter commented Mar 13, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.58%. Comparing base (2310a89) to head (135f971).
Report is 5 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1708   +/-   ##
=======================================
  Coverage   64.58%   64.58%           
=======================================
  Files         157      157           
  Lines       15839    15839           
=======================================
  Hits        10229    10229           
  Misses       4932     4932           
  Partials      678      678           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

🚀 New features to boost your workflow:
  • Test Analytics: Detect flaky tests, report on failures, and find test suite problems.
  • 📦 JS Bundle Analysis: Save yourself from yourself by tracking and limiting bundle sizes in JS merges.

@hogo6002 hogo6002 merged commit 5462bda into google:main Mar 13, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

3 participants