Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: move license scanning and all package flags out of experimental #1673

Merged
merged 5 commits into from
Feb 27, 2025

Conversation

hogo6002
Copy link
Contributor

This PR moves the --licenses and --all-packages flags out of experimental mode. Along with PR 1668, all our flags are now out of experimental mode.

@codecov-commenter
Copy link

codecov-commenter commented Feb 26, 2025

Codecov Report

Attention: Patch coverage is 80.00000% with 1 line in your changes missing coverage. Please review.

Project coverage is 64.59%. Comparing base (6b8b134) to head (ba7c8e4).
Report is 4 commits behind head on main.

Files with missing lines Patch % Lines
cmd/osv-scanner/internal/helper/helper.go 80.00% 1 Missing ⚠️
Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1673   +/-   ##
=======================================
  Coverage   64.59%   64.59%           
=======================================
  Files         156      156           
  Lines       16011    16011           
=======================================
  Hits        10343    10343           
  Misses       4986     4986           
  Partials      682      682           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@another-rex another-rex left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks! Added some comments

@hogo6002 hogo6002 enabled auto-merge (squash) February 27, 2025 02:57
@hogo6002 hogo6002 merged commit 2e8ac79 into google:main Feb 27, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants