Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add style to table details #1648

Conversation

vitorRibeiro7
Copy link
Contributor

@vitorRibeiro7 vitorRibeiro7 commented Feb 19, 2025

In this work a series of styles were added to improve the contrast of the accordions.

Resolving #1578

Verified

This commit was created on GitHub.com and signed with GitHub’s verified signature. The key has expired.
Copy link

google-cla bot commented Feb 19, 2025

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

…ble-accordion-containers
@another-rex
Copy link
Collaborator

another-rex commented Feb 19, 2025

Can you link the relevant issues in the PR description, and the changes made?

Also feel free to ignore the test failures, they will be resolved once you merge main into your branch. Do run ./scripts/run_formatter.sh though.

@hogo6002 hogo6002 requested a review from another-rex February 26, 2025 04:17
…ble-accordion-containers
@codecov-commenter
Copy link

codecov-commenter commented Mar 4, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 64.56%. Comparing base (1936ffe) to head (9054d4c).
Report is 3 commits behind head on main.

Additional details and impacted files
@@           Coverage Diff           @@
##             main    #1648   +/-   ##
=======================================
  Coverage   64.56%   64.56%           
=======================================
  Files         156      156           
  Lines       15987    15987           
=======================================
  Hits        10322    10322           
  Misses       4983     4983           
  Partials      682      682           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

@another-rex
Copy link
Collaborator

another-rex commented Mar 4, 2025

It looks like the drop shadow hiding didn't work because it was attached to the wrong element. Pushed the fix and remove the scrollbar changes for now.

@another-rex another-rex requested a review from hogo6002 March 4, 2025 04:20
@another-rex another-rex merged commit 11f4878 into google:main Mar 4, 2025
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

4 participants