-
Notifications
You must be signed in to change notification settings - Fork 406
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: add style to table details #1648
feat: add style to table details #1648
Conversation
Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA). View this failed invocation of the CLA check for more information. For the most up to date status, view the checks section at the bottom of the pull request. |
…ble-accordion-containers
Can you link the relevant issues in the PR description, and the changes made? Also feel free to ignore the test failures, they will be resolved once you merge main into your branch. Do run ./scripts/run_formatter.sh though. |
…ble-accordion-containers
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #1648 +/- ##
=======================================
Coverage 64.56% 64.56%
=======================================
Files 156 156
Lines 15987 15987
=======================================
Hits 10322 10322
Misses 4983 4983
Partials 682 682 ☔ View full report in Codecov by Sentry. |
It looks like the drop shadow hiding didn't work because it was attached to the wrong element. Pushed the fix and remove the scrollbar changes for now. |
In this work a series of styles were added to improve the contrast of the accordions.
Resolving #1578