Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Correct uses: line to reference the branch. #1

Merged
merged 2 commits into from Jul 10, 2020

Conversation

brycelelbach
Copy link
Contributor

A uses: line in a GitHub Action YML script must reference a branch with @. The example in README.md does not, which will cause errors if you copy it verbatim:

https://github.com/brycelelbach/github_pages_testing/actions/runs/164014798

@brycelelbach
Copy link
Contributor Author

I've got an existing signature of the Google CLA under this email address.

@jyasskin
Copy link
Collaborator

Let's use @v1 now that I've created it. I'll make that change and merge this tomorrow. Thanks!

@brycelelbach
Copy link
Contributor Author

brycelelbach commented Jul 10, 2020

SGTM - should be @v1.0 though, that's what the tag is called.

@brycelelbach
Copy link
Contributor Author

I updated the PR to @v1.0.

@jyasskin jyasskin merged commit 5d7016e into google:main Jul 10, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants