Use qualified Python names in metadata if available #18794
Merged
+2
−1
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
co_qualname
is the equivalent of__qualname__
in Python code.For a member function
then the
co_name
ofb
wasb
, and theco_qualname
of it isA.b
.These locations are propagated to XLA and the metadata of the compiled graph.
Depending on the coding style,
b
can be a very generic name (run
, or whatever) with the useful information contained in the class name,A
. In that case, having both in the metadata is more informative.Unfortunately before Python 3.11 then the qualified name was not available through the code object.
See #18764 for an example of the
co_name
-based metadata.cc: @nouiz