Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Guava 32.1.1 is not compatible with GWT because of System.nanoTime calls #6627

Closed
Arpic opened this issue Jul 6, 2023 · 2 comments
Closed

Comments

@Arpic
Copy link

Arpic commented Jul 6, 2023

After updating to Guava 32.1.1 we cannot compile our GWT project anymore because of changes to the @GwtCompatible Ticker class:

[ERROR] Errors in 'com/google/common/base/Ticker.java'
    [ERROR] Line 53: The method nanoTime() is undefined for the type System
Tracing compile failure path for type 'com.google.common.base.Ticker'
    [ERROR] Errors in 'com/google/common/base/Ticker.java'
        [ERROR] Line 53: The method nanoTime() is undefined for the type System

Is it an issue in our setup or an incompatible change ?

@cpovirk
Copy link
Member

cpovirk commented Jul 6, 2023

Ah, support for nanoTime() is new in GWT 2.10.0. I should have thought to investigate that. I'll mention it in the release notes.

Is upgrading to 2.10.0 practical?

@Arpic
Copy link
Author

Arpic commented Jul 6, 2023

Ah yes, I didn't think to check the GWT release notes, I will investigate whether it's possible for us to upgrade. Thanks for the quick answer.

@chaoren chaoren closed this as completed Jul 6, 2023
maltem-za added a commit to forTEXT/catma that referenced this issue Sep 5, 2023
... we're still on GWT 2.8.2 (see https://github.com/google/guava/releases/tag/v32.0.0); the security fixes made in guava 32.0.0 are not of concern as we don't use the affected classes and methods; oddly enough we were compiling without issues under guava 32.1.1, but compilation fails when attempting to run the dependency:analyze maven goal for example (with similar symptoms as google/guava#6627)
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

No branches or pull requests

3 participants