Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

listenablefuture and failureaccess are incompatible with Java's package module system #3564

Closed
shs96c opened this issue Aug 18, 2019 · 1 comment

Comments

@shs96c
Copy link

shs96c commented Aug 18, 2019

When included in the module-path the listenablefuture and failureaccess jars introduce classes that are also in the guava jar, causing a "split package", which causes all manner of chaos.

Although not including these jars on the module path might be possible, it's hard to determine in an automated way whether or not to include any random jar on the module path or not.

Since these jars should also have a module name, the better solution would be to move the classes within these jars to unique packages, thus avoiding the problem of a split package in the first place.

@cpovirk
Copy link
Member

cpovirk commented Aug 19, 2019

The failureaccess overlap is a bug fixed in 27.0.1 -- sorry about that.

With the listenablefuture overlap, users may have to manually exclude listenablefuture. We've set things up so that this is safe.

We may still make changes here. To keep that discussion in one place, we have #3320 for that.

@cpovirk cpovirk closed this as completed Aug 19, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

No branches or pull requests

2 participants