-
Notifications
You must be signed in to change notification settings - Fork 10.4k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
[ruby] Build/test ruby 3.3 and build native gems with Ruby 3.3 support #35399
Conversation
3dda32b
to
447de3a
Compare
447de3a
to
2de4404
Compare
Thx for kicking off the build @alto-ruby . Sanity tests are failing due to not locking the docker image versions for
The other test failures I couldn't see the correlation with the changes but rebased anyway, in case it's something fixed on |
@apolcyn for pushing new docker images |
2de4404
to
7db5e73
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
looks generally right - requested just a couple minor changes
Regarding testing
-
yes we ought to get in that PR you referenced. I'll be in office next week and can look at that.
-
we should create a "distribtest" for ruby 3.3 by adding an entry for it in
RubyDistribTest("linux", "x64", "ubuntu2204", presubmit=True),
(I'm out of the office right now but will be back next week, if the review needs more time).
Also I have pushed docker images and sent you a patch on this branch: chadlwilson#1
Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 Signed-off-by: Chad Wilson <chadw@thoughtworks.com>
195227d
to
5c14303
Compare
I've merged your changes, made the requested tweaks and rebased off master. Will need some help to kick off the build/test again (or point me to them) as now I can't see the build runs linked to the PR after the force pushes so not quite sure what the current pass/fail state is.
OK, will go with your and @alto-ruby guidance on whether that's a pre-requisite for this or something we can do subsequently. |
I've kicked off tests
Sounds good. I'm fine with the test changes to go in a subsequent PR. But still cc @alto-ruby for help on this aspect. |
Can someone point me to the appropriate build/test run invocation on |
Looks like everything is passing so that's a good sign 👍 |
@alto-ruby @apolcyn Edit: no problem, forgot about copybara flow. |
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628 (cherry picked from commit 43d2b28)
grpc#35399) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note grpc#31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes grpc#35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes grpc#35399 PiperOrigin-RevId: 599200628
…3.3 support (#35399)" (#35614) Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3. I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions) Fixes #35396 - Backport to `1.60` is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source. Closes #35399 PiperOrigin-RevId: 599200628 <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. --> Co-authored-by: Chad Wilson <chadw@thoughtworks.com>
Updates ruby-compiler-dock to 1.4.0 which brings Ruby 3.3 final support per https://github.com/rake-compiler/rake-compiler-dock/releases/tag/1.4.0 and starts cross-compiling for ruby 3.3.
I can't find obviously where the test infrastructure configuration is to run the tests under Ruby 3.3, so might need pointers or an accompanying PR for the test infra. (I note #31991 from @apolcyn so perhaps currently they are not run against newer versions)
Fixes #35396
1.60
is desirable since currently the Ruby gems cannot be installed with Ruby 3.3 and have to be built from source.