[fuzzing] Fix fuzzer found bug #33291
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ctiller
added
the
release notes: no
grpc-checks
bot
added
bloat/none
per-call-memory/neutral
per-channel-memory/neutral
labels
markdroth
approved these changes
May 31, 2023
| grpc_core::TraceFlagList::Set(strings[i] + 1, false); | ||
| namespace { | ||
| void ParseTracers(absl::string_view tracers) { | ||
| for (auto s : absl::StrSplit(tracers, ',')) { |
There was a problem hiding this comment.
I think you can use the absl::SkipWhitespace() predicate in absl::StrSplit() here, which will eliminate the need for the next two lines.
There was a problem hiding this comment.
I'll send a follow-up applying that a bit more widely!
copybara-service
bot
added
the
imported
eugeneo
pushed a commit
to eugeneo/grpc
that referenced
this pull request
Jun 1, 2023
We had an infinite recursion in our tracer parsing code... probably not a biggy, but it was blocking the fuzzers so fixing. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
mario-vimal
pushed a commit
to mario-vimal/grpc
that referenced
this pull request
Jun 15, 2023
We had an infinite recursion in our tracer parsing code... probably not a biggy, but it was blocking the fuzzers so fixing. <!-- If you know who should review your pull request, please assign it to that person, otherwise the pull request would get assigned randomly. If your pull request is for a specific language, please add the appropriate lang label. -->
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We had an infinite recursion in our tracer parsing code... probably not a biggy, but it was blocking the fuzzers so fixing.