Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[launcher] launcher can expose IPv6 ports as well #505

Merged
merged 1 commit into from
Oct 11, 2024
Merged

[launcher] launcher can expose IPv6 ports as well #505

merged 1 commit into from
Oct 11, 2024
+8 −2

Conversation

jkl73
Copy link
Contributor

@jkl73 jkl73 commented Oct 11, 2024

Previously, port opening only works on IPv4 traffic, now enabling it for IPv6 as well.

@jkl73
[launcher] launcher will expose IPv6 ports as well
Loading
Loading status checks…
d317682 
Previously, port opening only works on IPv4 traffic, now enabling
it for IPv6 as well.

Signed-off-by: Jiankun Lu <jiankun@google.com>
@jkl73
Copy link
Contributor Author

jkl73 commented Oct 11, 2024

/gcbrun

@jkl73 jkl73 requested a review from alexmwu October 11, 2024 05:44
@jkl73 jkl73 changed the title [launcher] launcher will expose IPv6 ports as well [launcher] launcher can expose IPv6 ports as well Oct 11, 2024
alexmwu
alexmwu approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@alexmwu alexmwu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Why did we need to separate this out from #487?

@jkl73
Copy link
Contributor Author

jkl73 commented Oct 11, 2024 •
edited
Loading

Why did we need to separate this out from #487?

#487 contains the new integration test which is currently failing due to the firewall setting the project. I will rebase #487 so it will only contains the test and submit it once the firewall setting is fixed.

@jkl73 jkl73 merged commit 52065b4 into google:main Oct 11, 2024
11 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@alexmwu alexmwu

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet
2 participants
@jkl73 @alexmwu