Instantiate backoff strategy per goroutine #496
Merged
+59
−44
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawangwang
force-pushed
the
replace_retry_library
branch
from
932d3d1 to
f5d7c57
Compare
|
/gcbrun |
jkl73
approved these changes
Sep 25, 2024
jkl73
reviewed
Sep 25, 2024
launcher/container_runner.go
Outdated
| MaxInterval = 3600 sec | ||
| MaxElapsedTime = 0 (never stops retrying) | ||
| WithCappedDuration = 3600 sec | ||
| MaxRetries = 8 |
There was a problem hiding this comment.
Should we keep the unlimited retry?
There was a problem hiding this comment.
my concern is the launcher will hang forever with unlimited retry if refreshToken keeps returning error. We might want the launcher exit in this case.
There was a problem hiding this comment.
nvm, this PR will use the original library, so we still keep the unlimited retry.
yawangwang
force-pushed
the
replace_retry_library
branch
2 times, most recently
from
87ef467 to
2780449
Compare
yawangwang
changed the title
|
/gcbrun |
JoshuaKrstic
requested changes
Sep 25, 2024
JoshuaKrstic
approved these changes
Sep 25, 2024
yawangwang
force-pushed
the
replace_retry_library
branch
from
2780449 to
b668068
Compare
alexmwu
approved these changes
Sep 25, 2024
yawangwang
force-pushed
the
replace_retry_library
branch
from
b668068 to
342de83
Compare
yawangwang
force-pushed
the
replace_retry_library
branch
from
342de83 to
a3f0425
Compare
|
/gcbrun |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Instantiate a new backoff object per goroutine since the current retry library is not thread-safe.
This PR also adds those tests related to
RefreshToken+FetchContainerSignaturesto a test suite with race condition check.