-
Notifications
You must be signed in to change notification settings - Fork 74
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add tempfs experiment and gate mounting behind it #490
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
I'm not sure why the cloud build is not failing but you don't actually mount a tmpfs in the cloud build. Probably due to the experiment not being there?
if echo $SERIAL_OUTPUT | grep -q "tmpfs.*${_TMPFS_SIZE_KB}.*/tmp/sized" |
Additionally, you aren't gating the /dev/shm feature. You can see /dev/shm size changes to from 64KB to 128000KB
It's probably the string in printed by the launcher "Mounts:[{Destination:/tmp/sized Size:222}]", together with the "tmpfs" print by the kernel, and some number in the timestamp causing the regex to pass the grep. Maybe adding "^" and "$" to the grep pattern in the test may do the trick. |
I think we can also try replacing |
Also we may want to add the flag here instead: go-tpm-tools/launcher/spec/launch_spec.go Line 180 in 03c656e
and go-tpm-tools/launcher/spec/launch_spec.go Line 191 in 03c656e
|
f3d2c10
to
0650961
Compare
/gcbrun |
f35f221
to
1d5cd42
Compare
/gcbrun |
function unexported, and Alex is OOO
* Add tempfs experiment and gate mounting behind it * Move experiments to launch spec and gate tempfs change there instead * fix tests by adding experiment flag * Move hosttpmpath creation to before the launchspec initialization * re-export UnmarshalLJson --------- Co-authored-by: Joshua Krstic <jkrstic@google.com>
--The binary still needs to be updated.-- Until then, this feature will always be off. Which is fine ofc.
The binary has been updated and the flag exists.