Removed experiment flags that we would no longer consider rolling back #483
+7
−21
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
JoshuaKrstic
force-pushed
the
removeExperiments
branch
from
76fb425 to
4c20867
Compare
JoshuaKrstic
force-pushed
the
removeExperiments
branch
from
4c20867 to
1a6f62a
Compare
yawangwang
reviewed
Sep 10, 2024
| @@ -12,9 +12,6 @@ import ( | |||
| // to treat experiment flags as their default value. The error should still be checked. | |||
| type Experiments struct { | |||
| EnableTestFeatureForImage bool | |||
| EnableSignedContainerImage bool | |||
| EnableOnDemandAttestation bool | |||
| EnableMemoryMonitoring bool | |||
| EnableSignedContainerCache bool | |||
| EnableMeasureMemoryMonitor bool | |||
There was a problem hiding this comment.
EnableSignedContainerCache + EnableMeasureMemoryMonitor have been in prod for a while, i think we can possibly remove them as well.
There was a problem hiding this comment.
Removing these is less trivial due to the agent class also generating tokens. Lets handle this in a follow up PR.
jkl73
approved these changes
Sep 10, 2024
|
/gcbrun |
jessieqliu
pushed a commit
that referenced
this pull request
Sep 25, 2024
#483) Co-authored-by: Joshua Krstic <jkrstic@google.com>
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing a number of experiments that we would not consider rolling back.