Log detailed errors if refreshing SA credential goes wrong #481
+34
−25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
yawangwang
changed the title
JoshuaKrstic
requested changes
Aug 28, 2024
yawangwang
force-pushed
the
add_loggings_for_fetching_container_signatures
branch
from
9e31470 to
dbaf3d7
Compare
|
/gcbrun |
JoshuaKrstic
approved these changes
Sep 10, 2024
jessieqliu
pushed a commit
that referenced
this pull request
Sep 25, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We have flaky long lived because container launcher failed to fetch container signatures with 403 errors.
Looks like the detailed error message is swallowed by pullTargetImage method where refreshing SA credentials first returns an error and then failover to fetching a public docker repo.
We should log the error message accordingly to determine what exactly went wrong.