Add version information and fix cloudbuild #455
Conversation
jkl73
force-pushed
the
showversion
branch
2 times, most recently
from
2dca42d to
9234966
Compare
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
1 similar comment
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
|
/gcbrun |
jkl73
changed the title
|
|
||
| "github.com/google/go-tpm-tools/cmd" | ||
| ) | ||
|
|
||
| // GoReleaser will populates those fields |
There was a problem hiding this comment.
how does it do this? I see https://pkg.go.dev/runtime/debug#ReadBuildInfo, does GoReleaser fill that out?
There was a problem hiding this comment.
yes, by default these three will be populated https://goreleaser.com/cookbooks/using-main.version/
| version = "dev" | ||
| commit = "none" | ||
| date = "unknown" |
There was a problem hiding this comment.
How does goreleaser populate these fields?
There was a problem hiding this comment.
when building the binary, using ldflags:
https://goreleaser.com/cookbooks/using-main.version/
launcher/image/preload.sh
Outdated
| @@ -128,6 +128,12 @@ main() { | |||
| "Only 'debug' and 'hardened' are supported." | |||
| exit 1 | |||
| fi | |||
|
|
|||
| # make sure files are copied | |||
| sync | |||
There was a problem hiding this comment.
Why is syncing required? Should we only sync the copy directory?
There was a problem hiding this comment.
So the symptom we saw in some image builds are files with 0 length in the OEM partition, I thought this might be because of files didn't copy through and the partition got umounted.
/usr/share/oem/confidential_space $ ls -althr
total 80M
drwxr-xr-x 4 root root 4.0K May 28 20:51 ..
-rwxr-xr-x 1 root root 55M May 28 20:51 confidential_space_experiments
-rwxr-xr-x 1 root root 26M May 28 20:51 cs_container_launcher
-rw-r--r-- 1 root root 0 May 28 20:51 container-runner.service
-rwxr-xr-x 1 root root 0 May 28 20:51 exit_script.sh
-rw-r--r-- 1 root root 0 May 28 20:51 fluent-bit-cs.conf
-rw-r--r-- 1 root root 0 May 28 20:51 system-stats-monitor-cs.json
-rw-r--r-- 1 root root 0 May 28 20:51 boot-disk-size-consistency-monitor-cs.json
-rw-r--r-- 1 root root 0 May 28 20:51 docker-monitor-cs.json
-rw-r--r-- 1 root root 0 May 28 20:51 kernel-monitor-cs.json
drwxr-xr-x 2 root root 4.0K May 28 20:51 .
Adding this to make sure all files are written to the disk.
There was a problem hiding this comment.
I changed to sync the oem directory only
|
/gcbrun |
| version = "dev" | ||
| commit = "none" | ||
| date = "unknown" |
Upgrade launcher cloudbuild to golang 1.21 Fix cloudbuild with empty oem files
launcher will also show build commit in the welcome message.
update launcher cloudbuild to go1.21 to match its go.mod
add "sync" at the end of the
preload.shfile to fix (hopefully) the empty files in OEM partition when building the image.