Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix invalid check and restore workaround from #72 #435

Merged
merged 2 commits into from
Apr 15, 2024

Conversation

savely-krasovsky
Copy link
Contributor

It seems this check was not valid for a while. This PR fixes that and restores unsealing for the old devices.

Verified

This commit was signed with the committer’s verified signature.
sake92 Sakib Hadžiavdić
Copy link

google-cla bot commented Apr 11, 2024

Thanks for your pull request! It looks like this may be your first contribution to a Google open source project. Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

View this failed invocation of the CLA check for more information.

For the most up to date status, view the checks section at the bottom of the pull request.

@savely-krasovsky
Copy link
Contributor Author

@jkl73 please review! I have found this bug after our discussion from #72.

@jkl73
Copy link
Contributor

jkl73 commented Apr 11, 2024

Also just out of my curiosity, do you the actual model and manufacturer of the TPM you facing the issue with? (is it a firmware TPM or a standalone TPM)

@savely-krasovsky
Copy link
Contributor Author

@jkl73 this is ST Microelectronics (STM).
Manufacturer version: 73.4.17568.4452
Spec version: 2.0
PPI spec version: 1.3
Subversion of TPM spec: 1.16 (9.21.2016)
Spec version of client computer: 1.00

Sorry, I could translate something wrong, user gave me only a screenshot of Windows Defender window in Russian:

Screenshot

@savely-krasovsky savely-krasovsky requested a review from jkl73 April 15, 2024 12:18
@jkl73 jkl73 merged commit 4a16fd0 into google:main Apr 15, 2024
10 of 11 checks passed
@jkl73
Copy link
Contributor

jkl73 commented Apr 15, 2024

Thanks for fixing this!

@savely-krasovsky savely-krasovsky deleted the old-lenovo-fix-2 branch April 15, 2024 20:23
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants