Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add sorting list options for secret scanning #3481

Merged
merged 1 commit into from
Feb 17, 2025

Conversation

maaarcelino
Copy link
Contributor

Similar to #3477 this adds the missing sorting options from the SecretScanningAlertListOptions struct.

These options are available in the list-secret-scanning-alerts-for-a-repository endpoint and the respective ones for orgs and enterprises.

@maaarcelino
Copy link
Contributor Author

maaarcelino commented Feb 17, 2025

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

@gmlewis
Copy link
Collaborator

gmlewis commented Feb 17, 2025

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

Yes, but it will probably be closer to this evening.

Copy link

codecov bot commented Feb 17, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 91.02%. Comparing base (81dc7a9) to head (da5a31a).
Report is 1 commits behind head on master.

Additional details and impacted files
@@           Coverage Diff           @@
##           master    #3481   +/-   ##
=======================================
  Coverage   91.02%   91.02%           
=======================================
  Files         179      179           
  Lines       15561    15561           
=======================================
  Hits        14165    14165           
  Misses       1223     1223           
  Partials      173      173           

☔ View full report in Codecov by Sentry.
📢 Have feedback on the report? Share it here.

Copy link
Collaborator

@gmlewis gmlewis left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thank you, @maaarcelino!
LGTM.
Merging.

@gmlewis gmlewis merged commit e4c974e into google:master Feb 17, 2025
7 checks passed
@gmlewis
Copy link
Collaborator

gmlewis commented Feb 17, 2025

@gmlewis After this is merged, could you cut another minor release, please? 🙏 I promise this is the last one 😄

This is now available here: https://github.com/google/go-github/releases/tag/v69.2.0

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants